summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamuel Munilla <smunilla@redhat.com>2016-01-12 14:27:43 -0500
committerSamuel Munilla <smunilla@redhat.com>2016-01-13 09:53:20 -0500
commit59dbd6d3dbd3d036119f4aee2203cf191ed68cee (patch)
tree621af88daa82c66d034c1a5d7678ec8edf0d6d8e
parent85c657669a202735bf6d4b96b02cbe7518b88485 (diff)
downloadopenshift-59dbd6d3dbd3d036119f4aee2203cf191ed68cee.tar.gz
openshift-59dbd6d3dbd3d036119f4aee2203cf191ed68cee.tar.bz2
openshift-59dbd6d3dbd3d036119f4aee2203cf191ed68cee.tar.xz
openshift-59dbd6d3dbd3d036119f4aee2203cf191ed68cee.zip
atomic-openshift-installer: Error handling for unicode hostnames
Fix error handling for invalid hostnames. Previously we were trying to print the offending hostname out, which caused errors due to python's handling of unicode strings. Seeing as how the user's input stays on the screen directly above the error there is no need to try and print it and we can avoid this problem entirely.
-rw-r--r--utils/src/ooinstall/cli_installer.py4
1 files changed, 1 insertions, 3 deletions
diff --git a/utils/src/ooinstall/cli_installer.py b/utils/src/ooinstall/cli_installer.py
index 2b6c9deee..4e30929da 100644
--- a/utils/src/ooinstall/cli_installer.py
+++ b/utils/src/ooinstall/cli_installer.py
@@ -33,9 +33,7 @@ def is_valid_hostname(hostname):
def validate_prompt_hostname(hostname):
if '' == hostname or is_valid_hostname(hostname):
return hostname
- raise click.BadParameter('"{}" appears to be an invalid hostname. ' \
- 'Please double-check this value i' \
- 'and re-enter it.'.format(hostname))
+ raise click.BadParameter('Invalid hostname. Please double-check this value and re-enter it.')
def get_ansible_ssh_user():
click.clear()