summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Gugino <mgugino@redhat.com>2017-10-20 09:22:29 -0400
committerMichael Gugino <mgugino@redhat.com>2017-10-20 09:22:29 -0400
commit9879c765a5a9cce14003aac26e414c84ec8e4cce (patch)
tree1e0f560ba26dd59988bb56a7459591fcb4046667
parente9a4c783e654fb65111633a537ff6842535733c8 (diff)
downloadopenshift-9879c765a5a9cce14003aac26e414c84ec8e4cce.tar.gz
openshift-9879c765a5a9cce14003aac26e414c84ec8e4cce.tar.bz2
openshift-9879c765a5a9cce14003aac26e414c84ec8e4cce.tar.xz
openshift-9879c765a5a9cce14003aac26e414c84ec8e4cce.zip
Remove incorrect validation for OpenIDIdentityProvider
Currently, OpenIDIdentityProvider does not support 'challenge=true' in openshift-ansible. This is incorrect, the auth plugin OpenIDIdentityProvider does support this. This commit removes the unnecessary validation of challenge key. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1444367 Fixes: https://github.com/openshift/openshift-ansible/issues/4417
-rw-r--r--roles/openshift_master_facts/filter_plugins/openshift_master.py1
1 files changed, 0 insertions, 1 deletions
diff --git a/roles/openshift_master_facts/filter_plugins/openshift_master.py b/roles/openshift_master_facts/filter_plugins/openshift_master.py
index f7f3ac2b1..a4f410296 100644
--- a/roles/openshift_master_facts/filter_plugins/openshift_master.py
+++ b/roles/openshift_master_facts/filter_plugins/openshift_master.py
@@ -363,7 +363,6 @@ class OpenIDIdentityProvider(IdentityProviderOauthBase):
def validate(self):
''' validate this idp instance '''
- IdentityProviderOauthBase.validate(self)
if not isinstance(self.provider['claims'], dict):
raise errors.AnsibleFilterError("|failed claims for provider {0} "
"must be a dictionary".format(self.__class__.__name__))