summaryrefslogtreecommitdiffstats
path: root/roles/lib_openshift/src
diff options
context:
space:
mode:
authorAndrew Butcher <abutcher@redhat.com>2017-05-15 15:48:46 -0400
committerAndrew Butcher <abutcher@redhat.com>2017-05-15 15:51:43 -0400
commit75c752d08f63852db6ba4df5f2c4380ba4bcbdc8 (patch)
treeff2a6a4a2bb7496d6e37a0bcd43c7a6fb592767e /roles/lib_openshift/src
parent47771c9270d3d3dbee4cc7e350efec479f86ecfa (diff)
downloadopenshift-75c752d08f63852db6ba4df5f2c4380ba4bcbdc8.tar.gz
openshift-75c752d08f63852db6ba4df5f2c4380ba4bcbdc8.tar.bz2
openshift-75c752d08f63852db6ba4df5f2c4380ba4bcbdc8.tar.xz
openshift-75c752d08f63852db6ba4df5f2c4380ba4bcbdc8.zip
Filter non-strings from the oc_adm_ca_server_cert hostnames parameter.
This allows the omit filter to be used in the hostnames parameter list which simplifies conditionally added hostnames.
Diffstat (limited to 'roles/lib_openshift/src')
-rw-r--r--roles/lib_openshift/src/ansible/oc_adm_ca_server_cert.py4
-rw-r--r--roles/lib_openshift/src/class/oc_adm_ca_server_cert.py4
2 files changed, 8 insertions, 0 deletions
diff --git a/roles/lib_openshift/src/ansible/oc_adm_ca_server_cert.py b/roles/lib_openshift/src/ansible/oc_adm_ca_server_cert.py
index 10f1c9b4b..fc394cb43 100644
--- a/roles/lib_openshift/src/ansible/oc_adm_ca_server_cert.py
+++ b/roles/lib_openshift/src/ansible/oc_adm_ca_server_cert.py
@@ -1,6 +1,10 @@
# pylint: skip-file
# flake8: noqa
+
+# pylint: disable=wrong-import-position
+from ansible.module_utils.six import string_types
+
def main():
'''
ansible oc adm module for ca create-server-cert
diff --git a/roles/lib_openshift/src/class/oc_adm_ca_server_cert.py b/roles/lib_openshift/src/class/oc_adm_ca_server_cert.py
index cf99a6584..37a64e4ef 100644
--- a/roles/lib_openshift/src/class/oc_adm_ca_server_cert.py
+++ b/roles/lib_openshift/src/class/oc_adm_ca_server_cert.py
@@ -96,6 +96,10 @@ class CAServerCert(OpenShiftCLI):
def run_ansible(params, check_mode):
'''run the idempotent ansible code'''
+ # Filter non-strings from hostnames list s.t. the omit filter
+ # may be used to conditionally add a hostname.
+ params['hostnames'] = [host for host in params['hostnames'] if isinstance(host, string_types)]
+
config = CAServerCertConfig(params['kubeconfig'],
params['debug'],
{'cert': {'value': params['cert'], 'include': True},