summaryrefslogtreecommitdiffstats
path: root/roles/nuage_node
diff options
context:
space:
mode:
authorKenny Woodson <kwoodson@redhat.com>2017-08-09 10:45:55 -0400
committerKenny Woodson <kwoodson@redhat.com>2017-08-09 10:45:55 -0400
commitba96f5eaf876f6b7568ac73794a08cbe759dceee (patch)
treeef9a38f8352079988a3ba08e4f4731f3c37de879 /roles/nuage_node
parent4f9b26e8af5890b7960291497020586426e7f1fc (diff)
downloadopenshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.tar.gz
openshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.tar.bz2
openshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.tar.xz
openshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.zip
Adding a default condition and removing unneeded defaults.
Diffstat (limited to 'roles/nuage_node')
-rw-r--r--roles/nuage_node/defaults/main.yml2
-rw-r--r--roles/nuage_node/tasks/firewall.yml8
2 files changed, 4 insertions, 6 deletions
diff --git a/roles/nuage_node/defaults/main.yml b/roles/nuage_node/defaults/main.yml
index c31c8a7dd..7a71273e7 100644
--- a/roles/nuage_node/defaults/main.yml
+++ b/roles/nuage_node/defaults/main.yml
@@ -5,7 +5,5 @@ r_nuage_node_os_firewall_deny: []
r_nuage_node_os_firewall_allow:
- service: vxlan
port: 4789/udp
- cond: true
- service: nuage-monitor
port: "{{ nuage_mon_rest_server_port }}/tcp"
- cond: true
diff --git a/roles/nuage_node/tasks/firewall.yml b/roles/nuage_node/tasks/firewall.yml
index cb0bffb09..008f3a95b 100644
--- a/roles/nuage_node/tasks/firewall.yml
+++ b/roles/nuage_node/tasks/firewall.yml
@@ -7,7 +7,7 @@
action: add
protocol: "{{ item.port.split('/')[1] }}"
port: "{{ item.port.split('/')[0] }}"
- when: item.cond
+ when: item.cond | default(True)
with_items: "{{ r_nuage_node_os_firewall_allow }}"
- name: Remove iptables rules
@@ -16,7 +16,7 @@
action: remove
protocol: "{{ item.port.split('/')[1] }}"
port: "{{ item.port.split('/')[0] }}"
- when: item.cond
+ when: item.cond | default(True)
with_items: "{{ r_nuage_node_os_firewall_deny }}"
- when: os_firewall_enabled | bool and os_firewall_use_firewalld | bool
@@ -27,7 +27,7 @@
permanent: true
immediate: true
state: enabled
- when: item.cond
+ when: item.cond | default(True)
with_items: "{{ r_nuage_node_os_firewall_allow }}"
- name: Remove firewalld allow rules
@@ -36,5 +36,5 @@
permanent: true
immediate: true
state: disabled
- when: item.cond
+ when: item.cond | default(True)
with_items: "{{ r_nuage_node_os_firewall_deny }}"