summaryrefslogtreecommitdiffstats
path: root/roles/openshift_node
diff options
context:
space:
mode:
authorKenny Woodson <kwoodson@redhat.com>2017-08-09 10:45:55 -0400
committerKenny Woodson <kwoodson@redhat.com>2017-08-09 10:45:55 -0400
commitba96f5eaf876f6b7568ac73794a08cbe759dceee (patch)
treeef9a38f8352079988a3ba08e4f4731f3c37de879 /roles/openshift_node
parent4f9b26e8af5890b7960291497020586426e7f1fc (diff)
downloadopenshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.tar.gz
openshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.tar.bz2
openshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.tar.xz
openshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.zip
Adding a default condition and removing unneeded defaults.
Diffstat (limited to 'roles/openshift_node')
-rw-r--r--roles/openshift_node/defaults/main.yml5
-rw-r--r--roles/openshift_node/tasks/firewall.yml8
2 files changed, 5 insertions, 8 deletions
diff --git a/roles/openshift_node/defaults/main.yml b/roles/openshift_node/defaults/main.yml
index 52218f683..92237757c 100644
--- a/roles/openshift_node/defaults/main.yml
+++ b/roles/openshift_node/defaults/main.yml
@@ -3,16 +3,13 @@ r_openshift_node_os_firewall_deny: []
r_openshift_node_os_firewall_allow:
- service: Kubernetes kubelet
port: 10250/tcp
- cond: true
- service: http
port: 80/tcp
- cond: true
- service: https
port: 443/tcp
- cond: true
- service: OpenShift OVS sdn
port: 4789/udp
- when: openshift.common.use_openshift_sdn | default(true) | bool
+ cond: openshift.common.use_openshift_sdn | default(true) | bool
- service: Calico BGP Port
port: 179/tcp
cond: "{{ openshift.common.use_calico | bool }}"
diff --git a/roles/openshift_node/tasks/firewall.yml b/roles/openshift_node/tasks/firewall.yml
index 323eaae70..492dcee1d 100644
--- a/roles/openshift_node/tasks/firewall.yml
+++ b/roles/openshift_node/tasks/firewall.yml
@@ -7,7 +7,7 @@
action: add
protocol: "{{ item.port.split('/')[1] }}"
port: "{{ item.port.split('/')[0] }}"
- when: item.cond
+ when: item.cond | default(True)
with_items: "{{ r_openshift_node_os_firewall_allow }}"
- name: Remove iptables rules
@@ -16,7 +16,7 @@
action: remove
protocol: "{{ item.port.split('/')[1] }}"
port: "{{ item.port.split('/')[0] }}"
- when: item.cond
+ when: item.cond | default(True)
with_items: "{{ r_openshift_node_os_firewall_deny }}"
- when: os_firewall_enabled | bool and os_firewall_use_firewalld | bool
@@ -27,7 +27,7 @@
permanent: true
immediate: true
state: enabled
- when: item.cond
+ when: item.cond | default(True)
with_items: "{{ r_openshift_node_os_firewall_allow }}"
- name: Remove firewalld allow rules
@@ -36,5 +36,5 @@
permanent: true
immediate: true
state: disabled
- when: item.cond
+ when: item.cond | default(True)
with_items: "{{ r_openshift_node_os_firewall_deny }}"