summaryrefslogtreecommitdiffstats
path: root/utils/src
diff options
context:
space:
mode:
authorDevan Goodwin <dgoodwin@redhat.com>2015-11-30 15:56:12 -0400
committerDevan Goodwin <dgoodwin@redhat.com>2015-11-30 15:56:12 -0400
commite796856c804cd7090ed45aba7838436e7fdc9580 (patch)
tree813f191d25342e3f8a3adccb33aa984f1144c2f2 /utils/src
parent4f6794ea6b3b7eb7383a74cb35e8ce6d445675c8 (diff)
downloadopenshift-e796856c804cd7090ed45aba7838436e7fdc9580.tar.gz
openshift-e796856c804cd7090ed45aba7838436e7fdc9580.tar.bz2
openshift-e796856c804cd7090ed45aba7838436e7fdc9580.tar.xz
openshift-e796856c804cd7090ed45aba7838436e7fdc9580.zip
Fix bug when warning on no dedicated nodes.
Diffstat (limited to 'utils/src')
-rw-r--r--utils/src/ooinstall/cli_installer.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/utils/src/ooinstall/cli_installer.py b/utils/src/ooinstall/cli_installer.py
index 8f9d82f43..f8dfe2feb 100644
--- a/utils/src/ooinstall/cli_installer.py
+++ b/utils/src/ooinstall/cli_installer.py
@@ -343,9 +343,8 @@ https://docs.openshift.org/latest/install_config/install/advanced_install.html#m
click.echo(message)
sys.exit(1)
- nodes = [host for host in oo_cfg.hosts if host.node]
- # TODO: This looks a little unsafe, maybe look for dedicated nodes only:
- if len(masters) == len(nodes):
+ dedicated_nodes = [host for host in oo_cfg.hosts if host.node and not host.master]
+ if len(dedicated_nodes) == 0:
message = """
WARNING: No dedicated Nodes specified. By default, colocated Masters have
their Nodes set to unscheduleable. If you proceed all nodes will be labelled