1 files changed, 47 insertions, 47 deletions
diff --git a/roles/openshift_logging/tasks/oc_apply.yaml b/roles/openshift_logging/tasks/oc_apply.yaml
index cb9509de1..c4db7d033 100644
--- a/roles/openshift_logging/tasks/oc_apply.yaml
+++ b/roles/openshift_logging/tasks/oc_apply.yaml
@@ -1,52 +1,52 @@
 ---
-- name: Checking generation of {{file_content.kind}} {{file_content.metadata.name}}
-  command: >
-    {{ openshift.common.client_binary }}
-    --config={{ kubeconfig }}
-    get {{file_content.kind}} {{file_content.metadata.name}}
-    -o jsonpath='{.metadata.resourceVersion}'
-    -n {{namespace}}
-  register: generation_init
-  failed_when: "'not found' not in generation_init.stderr and generation_init.stdout == ''"
-  changed_when: no
+- oc_obj:
+    kind: "{{ file_content.kind }}"
+    name: "{{ file_content.metadata.name }}"
+    state: present
+    namespace: "{{ namespace }}"
+    files:
+    - "{{ file_name }}"
+  when: file_content.kind != "Service"
 
-- name: Applying {{file_name}}
-  command: >
-    {{ openshift.common.client_binary }} --config={{ kubeconfig }}
-    apply -f {{ file_name }}
-    -n {{ namespace }}
-  register: generation_apply
-  failed_when: "'error' in generation_apply.stderr"
-  changed_when: no
+## still need to do this for services until the template logic is replaced by oc_*
+- block:
+  - name: Checking generation of {{file_content.kind}} {{file_content.metadata.name}}
+    command: >
+      {{ openshift.common.client_binary }}
+      --config={{ kubeconfig }}
+      get {{file_content.kind}} {{file_content.metadata.name}}
+      -o jsonpath='{.metadata.resourceVersion}'
+      -n {{namespace}}
+    register: generation_init
+    failed_when: "'not found' not in generation_init.stderr and generation_init.stdout == ''"
+    changed_when: no
 
-- name: Determine change status of {{file_content.kind}} {{file_content.metadata.name}}
-  command: >
-    {{ openshift.common.client_binary }} --config={{ kubeconfig }}
-    get {{file_content.kind}} {{file_content.metadata.name}}
-    -o jsonpath='{.metadata.resourceVersion}'
-    -n {{namespace}}
-  register: generation_changed
-  failed_when: "'not found' not in generation_changed.stderr and generation_changed.stdout == ''"
-  changed_when: generation_changed.stdout | default (0) | int  > generation_init.stdout | default(0) | int
-  when:
-    - "'field is immutable' not in generation_apply.stderr"
+  - name: Applying {{file_name}}
+    command: >
+      {{ openshift.common.client_binary }} --config={{ kubeconfig }}
+      apply -f {{ file_name }}
+      -n {{ namespace }}
+    register: generation_apply
+    failed_when: "'error' in generation_apply.stderr"
+    changed_when: no
 
-- name: Removing previous {{file_name}}
-  command: >
-    {{ openshift.common.client_binary }} --config={{ kubeconfig }}
-    delete -f {{ file_name }}
-    -n {{ namespace }}
-  register: generation_delete
-  failed_when: "'error' in generation_delete.stderr"
-  changed_when: generation_delete.rc == 0
-  when: "'field is immutable' in generation_apply.stderr"
+  - name: Removing previous {{file_name}}
+    command: >
+      {{ openshift.common.client_binary }} --config={{ kubeconfig }}
+      delete -f {{ file_name }}
+      -n {{ namespace }}
+    register: generation_delete
+    failed_when: "'error' in generation_delete.stderr"
+    changed_when: generation_delete.rc == 0
+    when: "'field is immutable' in generation_apply.stderr"
 
-- name: Recreating {{file_name}}
-  command: >
-    {{ openshift.common.client_binary }} --config={{ kubeconfig }}
-    apply -f {{ file_name }}
-    -n {{ namespace }}
-  register: generation_apply
-  failed_when: "'error' in generation_apply.stderr"
-  changed_when: generation_apply.rc == 0
-  when: "'field is immutable' in generation_apply.stderr"
+  - name: Recreating {{file_name}}
+    command: >
+      {{ openshift.common.client_binary }} --config={{ kubeconfig }}
+      apply -f {{ file_name }}
+      -n {{ namespace }}
+    register: generation_apply
+    failed_when: "'error' in generation_apply.stderr"
+    changed_when: generation_apply.rc == 0
+    when: "'field is immutable' in generation_apply.stderr"
+  when: file_content.kind == "Service"