1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
import pytest
from openshift_checks.etcd_volume import EtcdVolume, OpenShiftCheckException
@pytest.mark.parametrize('ansible_mounts,extra_words', [
([], ['none']), # empty ansible_mounts
([{'mount': '/mnt'}], ['/mnt']), # missing relevant mount paths
])
def test_cannot_determine_available_disk(ansible_mounts, extra_words):
task_vars = dict(
ansible_mounts=ansible_mounts,
)
check = EtcdVolume(execute_module=fake_execute_module)
with pytest.raises(OpenShiftCheckException) as excinfo:
check.run(tmp=None, task_vars=task_vars)
for word in 'Unable to find etcd storage mount point'.split() + extra_words:
assert word in str(excinfo.value)
@pytest.mark.parametrize('size_limit,ansible_mounts', [
(
# if no size limit is specified, expect max usage
# limit to default to 90% of size_total
None,
[{
'mount': '/',
'size_available': 40 * 10**9,
'size_total': 80 * 10**9
}],
),
(
1,
[{
'mount': '/',
'size_available': 30 * 10**9,
'size_total': 30 * 10**9,
}],
),
(
20000000000,
[{
'mount': '/',
'size_available': 20 * 10**9,
'size_total': 40 * 10**9,
}],
),
(
5000000000,
[{
# not enough space on / ...
'mount': '/',
'size_available': 0,
'size_total': 0,
}, {
# not enough space on /var/lib ...
'mount': '/var/lib',
'size_available': 2 * 10**9,
'size_total': 21 * 10**9,
}, {
# ... but enough on /var/lib/etcd
'mount': '/var/lib/etcd',
'size_available': 36 * 10**9,
'size_total': 40 * 10**9
}],
)
])
def test_succeeds_with_recommended_disk_space(size_limit, ansible_mounts):
task_vars = dict(
etcd_device_usage_threshold_percent=size_limit,
ansible_mounts=ansible_mounts,
)
if task_vars["etcd_device_usage_threshold_percent"] is None:
task_vars.pop("etcd_device_usage_threshold_percent")
check = EtcdVolume(execute_module=fake_execute_module)
result = check.run(tmp=None, task_vars=task_vars)
assert not result.get('failed', False)
@pytest.mark.parametrize('size_limit_percent,ansible_mounts,extra_words', [
(
# if no size limit is specified, expect max usage
# limit to default to 90% of size_total
None,
[{
'mount': '/',
'size_available': 1 * 10**9,
'size_total': 100 * 10**9,
}],
['99.0%'],
),
(
70.0,
[{
'mount': '/',
'size_available': 1 * 10**6,
'size_total': 5 * 10**9,
}],
['100.0%'],
),
(
40.0,
[{
'mount': '/',
'size_available': 2 * 10**9,
'size_total': 6 * 10**9,
}],
['66.7%'],
),
(
None,
[{
# enough space on /var ...
'mount': '/var',
'size_available': 20 * 10**9,
'size_total': 20 * 10**9,
}, {
# .. but not enough on /var/lib
'mount': '/var/lib',
'size_available': 1 * 10**9,
'size_total': 20 * 10**9,
}],
['95.0%'],
),
])
def test_fails_with_insufficient_disk_space(size_limit_percent, ansible_mounts, extra_words):
task_vars = dict(
etcd_device_usage_threshold_percent=size_limit_percent,
ansible_mounts=ansible_mounts,
)
if task_vars["etcd_device_usage_threshold_percent"] is None:
task_vars.pop("etcd_device_usage_threshold_percent")
check = EtcdVolume(execute_module=fake_execute_module)
result = check.run(tmp=None, task_vars=task_vars)
assert result['failed']
for word in extra_words:
assert word in result['msg']
def fake_execute_module(*args):
raise AssertionError('this function should not be called')
|
