summaryrefslogtreecommitdiffstats
path: root/roles
diff options
context:
space:
mode:
authorRodolfo Carvalho <rhcarvalho@gmail.com>2017-06-19 17:35:34 +0200
committerRodolfo Carvalho <rhcarvalho@gmail.com>2017-06-22 14:30:58 +0200
commit022cf67ea6be52ee46bb52aa6e78b9690698dc2e (patch)
tree4c5bd0ceaff12a0ec0d7f4319f9fc229149bae9d /roles
parent75082afc3a2cc9fed1966479dc31946962101488 (diff)
downloadopenshift-022cf67ea6be52ee46bb52aa6e78b9690698dc2e.tar.gz
openshift-022cf67ea6be52ee46bb52aa6e78b9690698dc2e.tar.bz2
openshift-022cf67ea6be52ee46bb52aa6e78b9690698dc2e.tar.xz
openshift-022cf67ea6be52ee46bb52aa6e78b9690698dc2e.zip
Add suggestion to check disk space in any path
Diffstat (limited to 'roles')
-rw-r--r--roles/openshift_health_checker/openshift_checks/disk_availability.py6
1 files changed, 5 insertions, 1 deletions
diff --git a/roles/openshift_health_checker/openshift_checks/disk_availability.py b/roles/openshift_health_checker/openshift_checks/disk_availability.py
index 2c4642352..638201495 100644
--- a/roles/openshift_health_checker/openshift_checks/disk_availability.py
+++ b/roles/openshift_health_checker/openshift_checks/disk_availability.py
@@ -66,7 +66,11 @@ class DiskAvailability(NotContainerizedMixin, OpenShiftCheck):
# If it is not a number, then it should be a nested dict.
pass
-
+ # TODO: as suggested in
+ # https://github.com/openshift/openshift-ansible/pull/4436#discussion_r122180021,
+ # maybe we could support checking disk availability in paths that are
+ # not part of the official recommendation but present in the user
+ # configuration.
for path, recommendation in self.recommended_disk_space_bytes.items():
free_bytes = self.free_bytes(path, ansible_mounts)
recommended_bytes = max(recommendation.get(name, 0) for name in group_names)